fix: show More Options for image selections - #455
Merged
pubuzhixing8 merged 1 commit intoJul 17, 2026
Conversation
Deploying drawnix with
|
| Latest commit: |
b1b0658
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://136947a6.drawnix.pages.dev |
| Branch Preview URL: | https://nightt5879-issue-439-mixed-s.drawnix.pages.dev |
Member
Author
pubuzhixing8
approved these changes
Jul 17, 2026
Contributor
|
@nightt5879 LGTM! |
pubuzhixing8
deleted the
nightt5879/issue-439-mixed-selection-more-options
branch
July 17, 2026 14:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Why
The popup toolbar was hidden whenever any selected element was an image. After the More Options menu was added, this also made its generic duplicate, delete, and copy actions unavailable for those selections.
Closes #439.
Testing
npx.cmd oxfmt --check packages/drawnix/src/components/toolbar/popup-toolbar/popup-toolbar.tsxnpx.cmd oxlint packages/drawnix/src/components/toolbar/popup-toolbar/popup-toolbar.tsxnpx.cmd nx test drawnix --skip-nx-cachenpx.cmd nx build drawnix --skip-nx-cache