Skip to content

fix: show More Options for image selections - #455

Merged
pubuzhixing8 merged 1 commit into
developfrom
nightt5879/issue-439-mixed-selection-more-options
Jul 17, 2026
Merged

fix: show More Options for image selections#455
pubuzhixing8 merged 1 commit into
developfrom
nightt5879/issue-439-mixed-selection-more-options

Conversation

@nightt5879

Copy link
Copy Markdown
Member

Summary

  • Keep the popup toolbar available when the selection contains an image.
  • Show only More Options for image and mixed-image selections, preserving the existing behavior for style controls.

Why

The popup toolbar was hidden whenever any selected element was an image. After the More Options menu was added, this also made its generic duplicate, delete, and copy actions unavailable for those selections.

Closes #439.

Testing

  • npx.cmd oxfmt --check packages/drawnix/src/components/toolbar/popup-toolbar/popup-toolbar.tsx
  • npx.cmd oxlint packages/drawnix/src/components/toolbar/popup-toolbar/popup-toolbar.tsx
  • npx.cmd nx test drawnix --skip-nx-cache
  • npx.cmd nx build drawnix --skip-nx-cache
  • Manually verified image and mixed-image selections in the local app.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying drawnix with  Cloudflare Pages  Cloudflare Pages

Latest commit: b1b0658
Status: ✅  Deploy successful!
Preview URL: https://136947a6.drawnix.pages.dev
Branch Preview URL: https://nightt5879-issue-439-mixed-s.drawnix.pages.dev

View logs

@nightt5879

Copy link
Copy Markdown
Member Author
image

@pubuzhixing8

Copy link
Copy Markdown
Contributor

@nightt5879 LGTM!

@pubuzhixing8
pubuzhixing8 merged commit db8b5c3 into develop Jul 17, 2026
2 checks passed
@pubuzhixing8
pubuzhixing8 deleted the nightt5879/issue-439-mixed-selection-more-options branch July 17, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to open more-options-button when user selected image and other elements

2 participants