ci: run the addon functional tests - #2710
Draft
acinader wants to merge 1 commit into
Draft
Conversation
acinader
force-pushed
the
ci-run-addon-tests
branch
from
August 29, 2026 22:40
813a7a5 to
2878793
Compare
hledger/test/cli/addons/ held generated, gitignored scripts from 2014 to 2026. CI excluded addons.test from 1afe5fb (2017-03-30), and the flag was copied into every shelltest step written since. 509e574 (2026-02-18) committed real scripts but did not remove the exclusion, so the tests run under functest and have not run in CI since. Same commit, same command, exclusion on and off: with -x /addons 1720 cases, 0 failed without it 1725 cases, 0 failed The delta is the five cases in addons.test. Checked on linux (ubuntu-24.04, this workflow) and mac arm64 (shelltest 1.11). Also drops "(excluding addons)" from the step names and the matching comment in _binaries-windows-arm64.yml. AI usage: Claude Opus 5, ~330k output tokens
acinader
force-pushed
the
ci-run-addon-tests
branch
from
August 31, 2026 16:18
2878793 to
1992482
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-x /addonsis vestigial. The condition it worked around was removed in 509e574.History
hledger/test/cli/addons/held generated, gitignored scripts from 2014 to 2026. CI excludedaddons.testfrom 1afe5fb (2017-03-30), and the flag was copied into every shelltest stepwritten since. 509e574 (2026-02-18) committed real scripts but did not remove the exclusion, so
the tests run under
functestand have not run in CI since.Verification
Same commit, same command, exclusion on and off:
-x /addons(current CI)The delta is the five cases in
addons.test, so they ran rather than being skipped silently.Also
comment in
_binaries-windows-arm64.yml._binaries-windows-arm64.ymlis updated for consistency.Relevance
#2699 adds 10 cases to
addons.testand 3 tocli.test. Under the current exclusion most ofthat PR's coverage would not run in CI.
This PR is mergeable but marked draft to comply with open PR policy.
AI usage: Claude Opus 5, ~10k output tokens