Skip to content

docs: trim WEBVIEW_MODAL canOpenURL comment #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-jimbo merged 1 commit into from
Aug 13, 2026
Merged

docs: trim WEBVIEW_MODAL canOpenURL comment #454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions Sources/Nubrick/Component/renderer/modal-component.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,10 @@ class ModalComponentViewController: UIViewController {
case .ignore:
return
case .openExternally(let urlObj):
// Best-effort fallback so non-http(s) never reach SFSafariViewController.
// Matches `openLink` in sdk.swift: canOpenURL then open.
//
// Note: canOpenURL returns false for third-party schemes not listed in the
// host app's LSApplicationQueriesSchemes. As an SDK we cannot set that
// Info.plist key, so custom schemes (e.g. myapp://) may no-op here.
// That is acceptable for WEBVIEW_MODAL — the supported case is http(s).
// Do not switch to open-without-canOpenURL just to paper over QueriesSchemes;
// broader deep-link open policy would be a separate change.
// Non-http(s) URLs are opened externally as a best-effort fallback.
// Custom schemes may return false unless the host app declares them in
// LSApplicationQueriesSchemes. This is acceptable because WEBVIEW_MODAL
// officially supports web URLs only.
guard UIApplication.shared.canOpenURL(urlObj) else {
return
}
Expand Down
Loading