fix: add BigtableAuthorizedView to KCC_USE_DIRECT_RECONCILERS - #10
Open
takaaki7 wants to merge 10 commits into
Open
fix: add BigtableAuthorizedView to KCC_USE_DIRECT_RECONCILERS#10takaaki7 wants to merge 10 commits into
takaaki7 wants to merge 10 commits into
Conversation
BigtableAuthorizedView has both a service mapping (TF path) and a direct controller registered. Without being listed in KCC_USE_DIRECT_RECONCILERS, KCC uses the TF path which silently fails because no Terraform resource exists for google_bigtable_authorized_view. This causes new CRs to be completely ignored with no logs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The controller registration requires an entry in ControllerConfigStatic (static_config.go) in addition to registry.RegisterModel. Without this, the controller logs "unrecognized CRD: BigtableAuthorizedView" and skips registration entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
…ncile
When RowPrefixes is not set in the CR spec (nil), the Update method
compared nil against the GCP API response ([][]byte{[]byte("")}),
always detecting a diff and triggering UpdateAuthorizedView.
Apply the same default value as Create method when RowPrefixes is nil,
so the comparison matches the actual GCP state.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: prevent unnecessary UpdateAuthorizedView API calls on every reconcile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KCC_USE_DIRECT_RECONCILERSにBigtableAuthorizedViewを追加google_bigtable_authorized_viewという Terraform リソースは存在しないため、TF コントローラーは新規 CR を完全に無視する（ログすら出ない）Root Cause
新しい BigtableAuthorizedView CR を作成しても、コントローラーが一切反応しない問題の根本原因。
Test plan
🤖 Generated with Claude Code