Fix socket lua shell print output going to local console and not to socket output - #383
Merged
pktgen merged 2 commits intoAug 31, 2026
Merged
Conversation
Signed-off-by: Luka Vretenar <luka.vretenar@gmail.com>
Remove {} around one line control statments.
pktgen
approved these changes
Aug 31, 2026
pktgen
left a comment
pktgen
left a comment
Owner
There was a problem hiding this comment.
Thanks, this one has been on the back burner for a while :-(
Contributor
Author
|
@pktgen glad to have it fixed. Appreciate the quick response and all the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The socket shell output from lua uses the
printglobal function to write the stack values after each execution in thedoREPLloop. By default the function is hardcoded in lua to print tostdout, writing all the values to the local console and not to the user connecting over the socket.This fix replaces the global
printfunction with one that writes to the redirected stdfiles that wrap the socket output.