Reword Lua script UI by gonzalo-bulnes · Pull Request #1 · pkendall64/ExpressLRS

gonzalo-bulnes · 2026-08-22T17:58:41Z

A few goals here:

make the UI fit the B&W displays
keep it clear on color displays
match the WebUI hierarchy as much as possible, so that:
- going from one to the other feels familiar (bench vs field for example)
- the structure of the docs doesn't require complicated branching of sections (Add Gyro feature documentation ExpressLRS/Docs#563)

To do:

Move Calibration folder to top level
Move [Stick Calibration] command to Main setup folder, like in the WebUI
Use invert instead of reverse for consistency with non-gyro output mapping
Use primary instead of master for input channels
Review the orientation options for length
Review the gyro mode switch type for length
Follow the moves of the gyro mode switch type and rate gain multiplier fields

gonzalo-bulnes · 2026-08-23T03:51:27Z

 static char gyroOffOn[] = "Off;On"; // Off-ON
 //  needs to match gyro_status_t
-static const char *gyroStatus[] = {"Off","IMU Not Detected","Need RX-Orientation","Need Stick Calibration","Running"};
+static const char *gyroStatus[] = {"Off","!Detected","!Orient.","!Stick cal","Running"};


These ones may be a bit controversial. I feel the ! conveys the idea of an error, even if someone doesn't necessarily read it as NOT, and space is really at a premium in these fields on B&W displays.

gonzalo-bulnes · 2026-08-23T03:52:00Z


 // Must match gyro_pidgroup_t
-static const char gyroPidGroup[] = "Rate (v/100);Level(v/100);AHRS (v/10)";
+static const char gyroPidGroup[] = "Rate (%);Level (%);AHRS (x0.1)";


I hope we can turn them all in % and move the unit next to the values.

Not necesary percentages.. there are weights for parameters in the algorithms

gonzalo-bulnes · 2026-08-23T03:52:48Z


 static folderParameter luaGyroPIDFolder = {
-    {"PIDs (Advanced)", CRSF_FOLDER},
+    {"Advanced (PIDs)", CRSF_FOLDER},


Guessing what the name of the corresponding panel in the WebUI could be. 💭

gonzalo-bulnes · 2026-08-23T03:54:21Z


 static folderParameter luaGyroFModeFolder = {
-    {"FMode Settings", CRSF_FOLDER},
+    {"Tuning", CRSF_FOLDER},


I'm not too sure about this vs Settings, but I followed the WebUI (where I think it "Gyro Mode Tuning" reads good. In the Lua script, "Gyro Mode" is the visible title of the menu.)

I think is more a Flight mode tuning... not general tuning

I suggested to move from "gyro flight mode" to "gyro mode", so that there is less room for confusion between the gyro modes and the typical EdgeTX "flight modes".

I've been highlighting gyro mode as a specific gyro concept across the docs, and I think it works well.

In this specific Lua screen, the title of the menu / page is Gyro Modes and it has two menu entries: Tuning and Advanced (PIDs). This echoes the WebUI Gyro Mode Tuning panel.

The full hierarchy to get there is: RX > Gyro > Gyro Modes > Tuning.

Respectively: RX > Gyro > Gyro Modes > Advanced (PIDs).

gonzalo-bulnes · 2026-08-23T03:55:20Z

            // Step 2: Stick Range Cal
            newStep = lcsAskConfirm;
-            msg = "Moved to all Sides/Corners?";
+            msg = "Move over full range";


Fighting for a few characters. 😬

gonzalo-bulnes · 2026-08-23T03:56:09Z


 static selectionParameter luaGyroFMode_StickPri = {
-    {"Stick Priority", CRSF_TEXT_SELECTION},
+    {"Stck priority", CRSF_TEXT_SELECTION},


There was just one character too many. IMHO this looks better than the ...y touching the value. YMMV.

gonzalo-bulnes · 2026-08-23T03:56:36Z


 static int8Parameter luaGyroFMode_AngLimitPitch = {
-    {"Limit Pitch", CRSF_UINT8},
+    {"Pitch limit", CRSF_UINT8},


Noun vs verb.

gonzalo-bulnes · 2026-08-23T03:58:04Z

        }
    },
-    " deg (+Left)"
+    " deg (+Lft)"


The closing parenthesis does get one pixel cut, but I think they still make the text clearer, and removing more letters from Left would pass the threshold of readability IMO.

gonzalo-bulnes · 2026-08-23T03:59:22Z

+            registerParameter(&luaGyroCalibrationFolder, nullptr, luaGyroMainFolder.common.id);
            registerParameter(&luaGyroModelFolder, nullptr, luaGyroMainFolder.common.id);
            registerParameter(&luaGyroModesFolder, nullptr, luaGyroModelFolder.common.id);
            registerParameter(&luaGyroOutputFolder, nullptr, luaGyroModelFolder.common.id);
            registerParameter(&luaGyroQuickSetupFolder, nullptr, luaGyroModelFolder.common.id);
            registerParameter(&luaGyroSettingsFolder, nullptr, luaGyroMainFolder.common.id);
            registerParameter(&luaGyroFModeFolder, nullptr, luaGyroSettingsFolder.common.id);
-            registerParameter(&luaGyroCalibrationFolder, nullptr, luaGyroSettingsFolder.common.id);


Moved to match the WebUI.

gonzalo-bulnes · 2026-08-23T04:00:16Z


            // ----- Gyro -> Model -> Stick Calibration
-            registerParameter(&luaGyroStickCal, [this](propertiesCommon *item, uint8_t arg) { luaparamGyroStickCal(item, arg); }, luaGyroCalibrationFolder.common.id);
+            registerParameter(&luaGyroStickCal, [this](propertiesCommon *item, uint8_t arg) { luaparamGyroStickCal(item, arg); }, luaGyroModelFolder.common.id);


Moved to match the WebUI.

Also WebUI and script do share docs, so aligning the hierarchy does help a lot in keeping the structure of the docs simple / easy to maintain.

We can't use the UART in the ISR in this mode so CRSF is delayed to the timeout call instead

Use a low-poly GLB and OGL for rendering Compass rose, artificial horizon & Ground plane Fix build by ignoring libraries before the LDF does its stupidity! Extract wizard to a common component & reuse for gyro wizards Export/Import configuration Validate setting in SetGyroConfig

I've no idea why, but this change did break the 'Gyro enabled' field. It went from displaying 'Gyro enabled: On' and being editable (On;Off), to display 'Gyro enabled: n' and not being editable.

The non-gyro Output mapping uses 'invert'.

The other channels with the same function do not follow the values of the primary as in a master/follower relationship; instead there is one primary input, which values are taken into account by the gyro, and secondary inputs which are ignored.

I had missed the fact that 'Level' groups all the level modes, so 'Mode group' is more accurate than 'Mode'. And the hint is actually useful, even though '(v/100)' was too long.

gonzalo-bulnes · 2026-08-23T11:33:07Z

(rebased to fix minor conflict)

gonzalo-bulnes · 2026-08-23T12:24:39Z

@pkendall64 I'm omitting updating the headers (web assets) to avoid generating pointless conflicts. Since you'll have to re-build the headers anyway...

sonarqubecloud · 2026-08-23T12:25:10Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pkendall64 · 2026-08-23T19:34:36Z

@gonzalo-bulnes probably what you should do is rebase this and drop the wifi commits i.e. the first 4 and the 2 simple changes and PR agains Frankies branch.
I can then make the simple changes to the web UI.

Mixing and matching which branch we're doing changes on is going to get very confusing.

gonzalo-bulnes · 2026-08-23T20:42:57Z

Sounds good @pkendall64 ! Makes sense, I'll do that. 👍 (Cc: @frankiearzu as a heads up 🙂)

gonzalo-bulnes · 2026-08-24T14:28:03Z

Closed in favor of frankiearzu#15

gonzalo-bulnes force-pushed the refine-lua-script-gyro-ui branch from 4adb02b to 609e524 Compare August 23, 2026 02:13

gonzalo-bulnes commented Aug 23, 2026

View reviewed changes

gonzalo-bulnes marked this pull request as ready for review August 23, 2026 04:00

pkendall64 force-pushed the wifi-config-mode branch from a7c7abe to 2c90af8 Compare August 23, 2026 04:06

pkendall64 added 2 commits August 23, 2026 19:21

Keep radio running in rx-wifi-config mode

d03572e

We can't use the UART in the ISR in this mode so CRSF is delayed to the timeout call instead

Fix build by ignoring libraries before the LDF does its stupidity!

474fd76

pkendall64 force-pushed the wifi-config-mode branch from 2c90af8 to edafd1e Compare August 23, 2026 07:30

pkendall64 added 2 commits August 23, 2026 20:04

Update web assets

9ed79ff

pkendall64 force-pushed the wifi-config-mode branch from edafd1e to 9ed79ff Compare August 23, 2026 08:05

gonzalo-bulnes added 8 commits August 23, 2026 11:27

Reword Lua script UI (see B&W displays)

2df7f4e

Revert rename Function_Inv to Function_R

d3b3448

I've no idea why, but this change did break the 'Gyro enabled' field. It went from displaying 'Gyro enabled: On' and being editable (On;Off), to display 'Gyro enabled: n' and not being editable.

Move Calibration folder to top level

3c35c5f

Move stick calibration command to main setup folder

0855c0b

Rename reverse to invert for consistency

55c940e

The non-gyro Output mapping uses 'invert'.

Rename master channel to primary channel

db9c178

The other channels with the same function do not follow the values of the primary as in a master/follower relationship; instead there is one primary input, which values are taken into account by the gyro, and secondary inputs which are ignored.

Restore unit hint on PID groups

ea3f326

I had missed the fact that 'Level' groups all the level modes, so 'Mode group' is more accurate than 'Mode'. And the hint is actually useful, even though '(v/100)' was too long.

Reword the gyro mode switch type label

2dec999

gonzalo-bulnes force-pushed the refine-lua-script-gyro-ui branch from 9cf7dc2 to dbdb146 Compare August 23, 2026 11:32

gonzalo-bulnes added 2 commits August 23, 2026 12:23

Add header to switch position functions list

473e16f

Minor add spacing to heading for readability

e47b65c

gonzalo-bulnes force-pushed the refine-lua-script-gyro-ui branch from d666d43 to e47b65c Compare August 23, 2026 12:23

pkendall64 force-pushed the wifi-config-mode branch from 9ed79ff to b6d43b7 Compare August 23, 2026 19:20

pkendall64 force-pushed the wifi-config-mode branch 2 times, most recently from c425dcf to 069d5a7 Compare August 23, 2026 21:16

pkendall64 force-pushed the wifi-config-mode branch 3 times, most recently from a3fd7de to ecacde0 Compare August 23, 2026 23:11

gonzalo-bulnes closed this Aug 24, 2026

Conversation

gonzalo-bulnes commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gonzalo-bulnes Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gonzalo-bulnes Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gonzalo-bulnes Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gonzalo-bulnes commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gonzalo-bulnes commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Aug 23, 2026

Quality Gate passed

Uh oh!

pkendall64 commented Aug 23, 2026

Uh oh!

gonzalo-bulnes commented Aug 23, 2026

Uh oh!

gonzalo-bulnes commented Aug 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gonzalo-bulnes commented Aug 22, 2026 •

edited

Loading

gonzalo-bulnes Aug 23, 2026 •

edited

Loading

gonzalo-bulnes Aug 23, 2026 •

edited

Loading

gonzalo-bulnes Aug 23, 2026 •

edited

Loading

gonzalo-bulnes commented Aug 23, 2026 •

edited

Loading

gonzalo-bulnes commented Aug 23, 2026 •

edited

Loading