Repository navigation
Conversation
Contributor
Author
|
The GnuTLS failure in CI Ubuntu is unrelated: pjsip-test aborted in the TCP keep-alive timer, which sent on a transport being closed. Could you rerun it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small follow-up to #5303. The practical gain is modest; it mostly makes the reset consistent.
After an IP change the resolver trusts the nameservers again, but still serves their cached errors, such as a refusal, for up to a minute. During that minute a SIP SRV lookup falls back to the domain's address. This happens only when the nameservers stay the same, e.g. a captive portal that refuses queries before login.
Now the reset drops the cached errors too. Other cached answers stay.
Left out: a lookup in flight during the reset may cache its error again.
Tested in resolver_test.