Skip to content

pjmedia-videodev: fix use-after-free crash in v4l2_scan_devs() #5327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nanangizz merged 2 commits into from
Oct 9, 2026
Merged

pjmedia-videodev: fix use-after-free crash in v4l2_scan_devs() #5327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc093f7
pjmedia-videodev: fix use-after-free crash in v4l2_scan_devs()
jeffreym-emt Oct 7, 2026
54b8ef1
Clean up old count and always true condition.
jeffreym-emt Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions pjmedia/src/pjmedia-videodev/v4l2_dev.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,16 +279,16 @@ static pj_status_t v4l2_scan_devs(vid4lin_factory *f)
{
vid4lin_dev_info vdi[V4L2_MAX_DEVS];
char dev_name[32];
unsigned i, old_count;
unsigned i;
pj_status_t status;

if (f->dev_pool) {
pj_pool_release(f->dev_pool);
f->dev_pool = NULL;
f->dev_info = NULL;
}

pj_bzero(vdi, sizeof(vdi));
old_count = f->dev_count;
f->dev_count = 0;
f->dev_pool = pj_pool_create(f->pf, DRIVER_NAME, 500, 500, NULL);

Expand Down Expand Up @@ -368,7 +368,7 @@ static pj_status_t v4l2_scan_devs(vid4lin_factory *f)

v4l2_close(fd);

if (j < fmt_cnt)
if (pdi->info.fmt_cnt == 0)
continue;

f->dev_count++;
Expand All @@ -377,12 +377,11 @@ static pj_status_t v4l2_scan_devs(vid4lin_factory *f)
if (f->dev_count == 0)
return PJ_SUCCESS;

if (f->dev_count > old_count || f->dev_info == NULL) {
f->dev_info = (vid4lin_dev_info*)
pj_pool_calloc(f->dev_pool,
f->dev_count,
sizeof(vid4lin_dev_info));
}
f->dev_info = (vid4lin_dev_info*)
pj_pool_calloc(f->dev_pool,
f->dev_count,
sizeof(vid4lin_dev_info));

pj_memcpy(f->dev_info, vdi, f->dev_count * sizeof(vid4lin_dev_info));

return PJ_SUCCESS;
Expand Down
Loading