Repository navigation
Dashboard: a run that left packs alive is no full clear - #302
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TortoiseBots run leader now adds an optional trailing field to its status line when it left packs alive:
TBM:RUN|...|<note>|left <K>(only when K > 0; TortoiseBots branch fix/defer-unreachable-pack). Until now the agent folded it into the note and the dashboard counted such a run as a full clear.internal/tbm:ParseRunLinereads a trailingleft <digits>intoRunStatus.Leftand strips it from the note; lines without it parse as before.internal/dashboard: a run is complete only as a confirmed clean clear (reason == "done", from the first leg,Left == 0), one helper used by Complete and by the ghost's tie-break; everyrun_leaderevent sets the count, so a later zero clears an earlier one; the dashboard shows the packs left.internal/dungeon: observe mode carries the count through.Tests: parser with and without the field, a note with "left" text, a count that drops to zero, ghost tie-breaks (clean vs dirty, aborted vs done).
make testpasses.Reviews: three Codex rounds, each finding fixed (stale count, ghost tie-break, aborted runs counted as clean).