Repository navigation
Zul'Farrak: pull the pair before the camp, with approach points (r2-19z19 step 26 wipes); generic approach-clearance check - #281
Merged
Conversation
… approach-clearance plan check (r2-19z19 step 26)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 2 on 19z19: the Zul'Farrak run wiped twice at step 26 (the camp at 1666.77 903.85). Cause (PLAN-ZF-STEP26): the changed route pulled the camp before the pair [5648,7247] standing between the party and the camp; the camp step had no approach row, so the run leader stopped 30 yd short (15.4 yd from the pair's 5648) and the pair aggroed during the walk. Fix: antusul order = Witch Doctor 1633.3 868.3, the pair (patrol block kept), the camp, the north pack, as in the 19z16 clear; approach points 1620 880 z 8.97 (pair) and 1630 878 z 8.93 (camp), navmesh floors. New check internal/dungeon/approach_clear_test.go: a pull's stand (last approach point, or 30 yd short of the group centre from the previous group) must stay 20 yd from later groups (23 computed, 3 yd drift) and 15 yd from patrol paths; it FAILS on the old order (mutation proof) and fails only for the two guarded Zul'Farrak groups, other findings (other plans, 31 more in Zul'Farrak) are report-only and not fixed. Reviews: Opus cold review (SHIP). KNOWN LIMITS (from the review, not fixed here): (1) the 155626 patrol still passes the camp: with DungeonRunPullStand on, the camp pull's firing stand lands about 1.6 yd from the patrol path, so the 19.6 yd figure holds only for the approach point; cause 2 of the step 26 wipes (the patrol) needs module support for patrols; (2) the north pack's stand is 9.2 yd from the patrol path (report-only); (3) creatures in no group are not checked. Zerillis (10082) stays in the skip lists (agent-led driver only; the exporter drops skip lists, so no module row changes).