Repository navigation
Observe counts wipes once; cmd enter is sent at a door above the ground (Ragefire Chasm) - #280
Merged
Merged
Conversation
countDeaths()' result was dropped in the watch loop, so report.wipes stayed 0 for a whole observed run. An edge flag keeps three polls of the same dead party at one wipe and lets a party that came back alive be wiped again.
A portal in a cave or on a ledge stands off the ground the lead bot walks, so the 3D MoveArrive check never passed and the walk ran to the 4-minute ceiling without an order (stuck at the portal's x/y). With cmd enter the lead bot counts as at the door within 30 yd on the ground plane and 12 yd of height; the plain walk still needs the point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from round 1 on 19z18. (1) observe.go: the watch loop kept countDeaths()'s result nowhere, so report.wipes was always 0 in observe runs (the Ragefire Chasm run had two 5-dead collapses and reported 0; Uldaman 1 wipe reported 0). A wipe is now counted once on the rising edge of 'all dead' (observeState.wiped); 4 of 5 dead is 0. (2) remote_enter.go walkToPortal: with the module's cmd enter the lead counts as at the door within 30 yd horizontal and 12 yd height (new const cmdEnterDoorDZ), because the plan's portal point is the area trigger centre about 9 yd above the floor and the 3D 5 yd arrival check made the walk run to the 4-minute ceiling ('stuck at 304.0 0.0 0.0'); the module's order walks each bot to the trigger itself. The plain walk without cmd enter is unchanged. Tests fail before and pass after on a clean dev worktree; go test ./... clean (38 packages); README updated. Reviews: Sonnet cold review (SHIP). Not run live. Known: one flaky test in internal/session (TestKnockBackLandsOnASlope) under full-suite load, unrelated.