Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ categories = ["network-programming"]
description = "Small library to allow cross-platform handling of IP_PKTINFO and IPV6_PKTINFO with socket2 crate"

[dependencies.socket2]
version = "0.5.8"
version = "0.6.0"
features = ["all"]

[target.'cfg(windows)'.dependencies.windows-sys]
Expand Down
16 changes: 5 additions & 11 deletions src/unix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use std::net::{IpAddr, Ipv4Addr, Ipv6Addr};
use std::os::unix::io::{AsRawFd, RawFd};
use std::{io, mem, ptr};

use socket2::{Domain, Protocol, SockAddr, Socket, Type};
use socket2::{Domain, Protocol, SockAddr, SockAddrStorage, Socket, Type};

use crate::PktInfo;

Expand Down Expand Up @@ -133,7 +133,7 @@ impl PktInfoUdpSocket {
}

pub fn recv(&self, buf: &mut [u8]) -> io::Result<(usize, PktInfo)> {
let mut addr_src: MaybeUninit<libc::sockaddr_storage> = MaybeUninit::uninit();
let mut addr_src = SockAddrStorage::zeroed();
let mut msg_iov = IoSliceMut::new(buf);
let mut cmsg = {
let space = if self.domain == Domain::IPV4 {
Expand All @@ -151,7 +151,7 @@ impl PktInfoUdpSocket {
let mut mhdr = unsafe {
let mut mhdr = MaybeUninit::<libc::msghdr>::zeroed();
let p = mhdr.as_mut_ptr();
(*p).msg_name = addr_src.as_mut_ptr() as *mut libc::c_void;
(*p).msg_name = addr_src.view_as::<libc::c_void>();
(*p).msg_namelen = mem::size_of::<libc::sockaddr_storage>() as libc::socklen_t;
(*p).msg_iov = &mut msg_iov as *mut IoSliceMut as *mut libc::iovec;
(*p).msg_iovlen = 1;
Expand All @@ -167,14 +167,8 @@ impl PktInfoUdpSocket {
return Err(Error::last_os_error());
}

let addr_src = unsafe {
SockAddr::new(
addr_src.assume_init(),
mem::size_of::<libc::sockaddr_storage>() as _,
)
}
.as_socket()
.unwrap();
let len = addr_src.size_of();
let addr_src = unsafe { SockAddr::new(addr_src, len) }.as_socket().unwrap();

let mut header = if mhdr.msg_controllen > 0 {
debug_assert!(!mhdr.msg_control.is_null());
Expand Down
11 changes: 5 additions & 6 deletions src/win.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use std::net::{IpAddr, Ipv4Addr, Ipv6Addr};
use std::os::windows::io::{AsRawSocket, RawSocket};
use std::{io, mem, ptr};

use socket2::{Domain, Protocol, SockAddr, Socket, Type};
use socket2::{Domain, Protocol, SockAddr, SockAddrStorage, Socket, Type};
use windows_sys::core::{PCSTR, PSTR};
use windows_sys::Win32::Networking::WinSock::{
self, CMSGHDR, IN6_PKTINFO, IN_PKTINFO, IPPROTO_IP, IPPROTO_IPV6, IPV6_PKTINFO, IP_PKTINFO,
Expand Down Expand Up @@ -196,10 +196,10 @@ impl PktInfoUdpSocket {
},
};

let mut addr = unsafe { mem::zeroed() };
let mut addr = SockAddrStorage::zeroed();
let mut wsa_msg = WSAMSG {
name: &mut addr as *mut _ as *mut _,
namelen: mem::size_of_val(&addr) as i32,
namelen: addr.size_of(),
lpBuffers: &mut data,
Control: control,
dwBufferCount: 1,
Expand All @@ -223,9 +223,8 @@ impl PktInfoUdpSocket {
return Err(io::Error::last_os_error());
}

let addr_src = unsafe { SockAddr::new(addr, mem::size_of_val(&addr) as i32) }
.as_socket()
.unwrap();
let len = addr.size_of();
let addr_src = unsafe { SockAddr::new(addr, len) }.as_socket().unwrap();

let mut info: Option<PktInfo> = None;

Expand Down
Loading