Repository navigation
fix: remove malformed precision declaration in convolution3x3 desktop shader - #245
Merged
parkergrt merged 1 commit intoAug 29, 2026
Merged
Conversation
… shader - the desktop GL fragment shader for Convolution3x3Filter declared "precision float;" which is missing the precision qualifier and is a GLSL syntax error, so the shader fails to compile on desktop GL - desktop GL branches in the other filters declare no default precision at all, so drop the line to match
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The desktop GL fragment shader in
src/filter/convolution3x3_filter.cc(theGPUPIXEL_GL_SHADERbranch) starts with:The precision statement is missing its qualifier (
lowp/mediump/highp), which is a GLSL syntax error. On a desktop GL context the shader fails to compile, so Convolution3x3Filter and every filter derived from it cannot initialize.Fix
Remove the malformed line. Desktop GLSL does not require a default precision declaration, and none of the other filters'
GPUPIXEL_GL_SHADERbranches declare one, so the desktop shader now starts with the sampler uniform like its neighbors.Verification
ERROR: 0:2: 'precision' : syntax error, after the change it compiles clean.script/build_macos.shbuilds successfully with the change.clang-format --dry-run -Werrorreports no issues on the changed file.