Skip to content

Expose applyProps - #634

Merged
trezy merged 2 commits into
pixijs:mainfrom
lunarraid:expose-apply-props
Nov 17, 2025
Merged

trezy merged 2 commits into
pixijs:mainfrom
lunarraid:expose-apply-props

Conversation

@lunarraid

Copy link
Copy Markdown
Collaborator

In order to add a react-spring target, we need a way to 'natively' apply props without a re-render. I figure exposing this method is the easiest way to do so since it is what is called on render anyway.

@trezy
trezy self-requested a review November 17, 2025 17:37
@trezy
trezy requested a review from thejustinwalsh November 17, 2025 17:38
@trezy trezy added enhancement New feature or request v8 Issues related to Pixi React v8 labels Nov 17, 2025

@trezy trezy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

thejustinwalsh
thejustinwalsh previously approved these changes Nov 17, 2025

@thejustinwalsh thejustinwalsh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's go!

@trezy
trezy self-requested a review November 17, 2025 17:39

@trezy trezy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we merge, @lunarraid, can you update the index test to verify this export isn't accidentally removed in the future?
https://github.com/pixijs/pixi-react/blob/main/test/unit/index.test.ts

@trezy trezy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trezy
trezy merged commit 1a6ae91 into pixijs:main Nov 17, 2025
6 checks passed
@lunarraid
lunarraid deleted the expose-apply-props branch November 17, 2025 17:54
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 8.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request released v8 Issues related to Pixi React v8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants