Skip to content

fix: CI: move "Semantic release" step - #633

Closed
MaksimKiselev wants to merge 1 commit into
pixijs:mainfrom
MaksimKiselev:main
Closed

MaksimKiselev wants to merge 1 commit into
pixijs:mainfrom
MaksimKiselev:main

Conversation

@MaksimKiselev

Copy link
Copy Markdown

Move Semantic release step before Build Project to fix version in the final bundle.

#631 (comment)

@thejustinwalsh
thejustinwalsh requested a review from trezy December 1, 2025 21:24
@trezy

trezy commented Dec 1, 2025

Copy link
Copy Markdown
Collaborator

I've just verified that the version in package.json is set correctly for releases, so this would just add an unnecessary build when there's no relevant version updates.

@trezy trezy closed this Dec 1, 2025
@MaksimKiselev

MaksimKiselev commented Jan 30, 2026

Copy link
Copy Markdown
Author

@trezy hi!

Version in package.json is correct.

But the version in the bundled version of package.json is not correct:
image

image

When I manually fix the version in the dist/pixi-react.js file, the error disappears and the React DevTools start working correctly.


My original comment:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants