Skip to content

[Issue #176] align Pixels block loading with Trino 466 #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengdy1545 wants to merge 1 commit into from
Closed

[Issue #176] align Pixels block loading with Trino 466 #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions connector/src/main/java/io/pixelsdb/pixels/trino/PixelsBlockLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import io.airlift.slice.Slices;
import io.pixelsdb.pixels.core.TypeDescription;
import io.pixelsdb.pixels.core.vector.*;
import io.pixelsdb.pixels.trino.block.TimeArrayBlock;
import io.pixelsdb.pixels.trino.block.VarcharArrayBlock;
import io.pixelsdb.pixels.trino.block.VarcharArrayBlockEncoding;
import io.trino.spi.block.*;
Expand Down Expand Up @@ -70,7 +69,26 @@ public Block load()
switch (typeCategory)
{
case BYTE:
ByteColumnVector bytecv = (ByteColumnVector) vector;
block = new ByteArrayBlock(batchSize, Optional.ofNullable(bytecv.isNull), bytecv.vector);
break;
case SHORT:
IntColumnVector shortcv = (IntColumnVector) vector;
short[] shortValues = new short[batchSize];
for (int i = 0; i < batchSize; ++i)
{
if (!shortcv.isNull[i])
{
int value = shortcv.vector[i];
if (value < Short.MIN_VALUE || value > Short.MAX_VALUE)
{
throw new IllegalArgumentException("SMALLINT value out of range: " + value);
}
shortValues[i] = (short) value;
}
}
block = new ShortArrayBlock(batchSize, Optional.ofNullable(shortcv.isNull), shortValues);
break;
case INT:
IntColumnVector icv = (IntColumnVector) vector;
block = new IntArrayBlock(batchSize, Optional.ofNullable(icv.isNull), icv.vector);
Expand Down Expand Up @@ -146,12 +164,12 @@ public Block load()
case TIME:
// PIXELS-94: add time type.
TimeColumnVector tcv = (TimeColumnVector) vector;
/**
* In Presto, LongArrayBlock is used for time type. However, in Pixels,
* Time value is stored as int, so here we use TimeArrayBlock, which
* accepts int values but provides getLong method same as LongArrayBlock.
*/
block = new TimeArrayBlock(batchSize, tcv.times, !tcv.noNulls, tcv.isNull);
long[] timeValues = new long[batchSize];
for (int i = 0; i < batchSize; ++i)
{
timeValues[i] = (long) tcv.times[i] * 1_000_000_000L;
}
block = new LongArrayBlock(batchSize, Optional.ofNullable(tcv.isNull), timeValues);
break;
case TIMESTAMP:
TimestampColumnVector tscv = (TimestampColumnVector) vector;
Expand Down
3 changes: 1 addition & 2 deletions connector/src/main/java/io/pixelsdb/pixels/trino/PixelsPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
package io.pixelsdb.pixels.trino;

import com.google.common.collect.ImmutableList;
import io.pixelsdb.pixels.trino.block.TimeArrayBlockEncoding;
import io.pixelsdb.pixels.trino.block.VarcharArrayBlockEncoding;
import io.trino.spi.Plugin;
import io.trino.spi.block.BlockEncoding;
Expand All @@ -31,7 +30,7 @@ public class PixelsPlugin implements Plugin
@Override
public Iterable<BlockEncoding> getBlockEncodings()
{
return ImmutableList.of(VarcharArrayBlockEncoding.Instance(), TimeArrayBlockEncoding.Instance());
return ImmutableList.of(VarcharArrayBlockEncoding.Instance());
}

@Override
Expand Down
Loading