Skip to content

[Issue #173] Avoid duplicate acquisition of virtual nodes when retrieving BufferSplits #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bianhq merged 3 commits into from
Aug 5, 2026
Merged

[Issue #173] Avoid duplicate acquisition of virtual nodes when retrieving BufferSplits #174

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07de280
Fix duplicate get BufferSplits
AntiO2 Apr 28, 2026
2fa9926
Add GetRetinaBuffer Option
AntiO2 Jul 11, 2026
c3eb9ce
Remove prop
AntiO2 Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions connector/src/main/java/io/pixelsdb/pixels/trino/PixelsSplitManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@
public class PixelsSplitManager implements ConnectorSplitManager
{
private static final Logger logger = Logger.get(PixelsSplitManager.class);
private static final String RETINA_ENABLE = "retina.enable";
private static final String RETINA_BUFFER_SPLIT_ENABLE = "retina.buffer.split.enable";
private final String connectorId;
private final PixelsMetadataProxy metadataProxy;
private final PixelsTrinoConfig config;
Expand Down Expand Up @@ -463,8 +465,7 @@ public ConnectorSplitSource getSplits(ConnectorTransactionHandle trans,
.collect(Collectors.toList());
}

String retinaEnabled = config.getConfigFactory().getProperty("retina.enable");
if (retinaEnabled != null && retinaEnabled.equalsIgnoreCase("true"))
if (isRetinaBufferSplitEnabled())
{
List<PixelsBufferSplit> pixelsBufferSplits = getBufferSplits(transHandle, session, tableHandle,
pixelsSplits.size());
Expand Down Expand Up @@ -1356,6 +1357,18 @@ private List<PixelsFileSplit> getScanSplits(PixelsTransactionHandle transHandle,
return pixelsSplits;
}

private boolean isRetinaBufferSplitEnabled()
{
String retinaEnabled = config.getConfigFactory().getProperty(RETINA_ENABLE);
if (!Boolean.parseBoolean(retinaEnabled))
{
return false;
}

String bufferSplitEnabled = config.getConfigFactory().getProperty(RETINA_BUFFER_SPLIT_ENABLE);
return bufferSplitEnabled == null || Boolean.parseBoolean(bufferSplitEnabled);
}

private List<PixelsBufferSplit> getBufferSplits(PixelsTransactionHandle transHandle, ConnectorSession session,
PixelsTableHandle tableHandle, long splitId) throws MetadataException, RetinaException
{
Expand Down Expand Up @@ -1388,18 +1401,15 @@ private List<PixelsBufferSplit> getBufferSplits(PixelsTransactionHandle transHan
{
HostAddress address = HostAddress.fromString(retinaAddress.getAddress() + ":" + retinaPort);

for(int virtualNodeId = 0; virtualNodeId < virtualNodeNum; ++virtualNodeId)
{
PixelsBufferSplit split = new PixelsBufferSplit(transHandle.getTransId(), splitId++, connectorId,
schemaName, tableName, tableId, virtualNodeId,
storageScheme,
List.of(address),
columnOrder, emptyConstraint, // maybe useless
originColumnCnt,
schema.toString()
);
pixelsBufferSplits.add(split);
}
PixelsBufferSplit split = new PixelsBufferSplit(transHandle.getTransId(), splitId++, connectorId,
schemaName, tableName, tableId, retinaAddress.getVirtualNodeId(),
storageScheme,
List.of(address),
columnOrder, emptyConstraint, // maybe useless
originColumnCnt,
schema.toString()
);
pixelsBufferSplits.add(split);
}
return pixelsBufferSplits;
}
Expand Down