[TASK] CGL - #4
Open
kaystrobach wants to merge 6 commits into
Open
Conversation
mabolek
self-requested a review
March 27, 2020 15:03
mabolek
suggested changes
Mar 27, 2020
mabolek
left a comment
mabolek
left a comment
Contributor
There was a problem hiding this comment.
Hi @kaystrobach!
I love this! I've been wanting to do something similar for a long time.
Do you have any further plans in this direction?
This is anyway a perfect starting point for some really nice stuff, so thank you!
I had one minor comment to the PR. Then I'll merge this into a new branch and change the namespace, if that's all right. :-)
Author
|
I’m still in the refactoring process, found quite some bugs in the other php file and need to understand what they are doing. I do also want to switch to the platform sh client instead of relying on the cli tool ... |
Co-authored-by: Mathias Bolt Lesniak <mathias@lilio.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.