QL_fileOrder#9
Open
bdek wants to merge 1 commit into
Open
Conversation
…ve time per the filename
jmw182
reviewed
Apr 14, 2025
jmw182
left a comment
jmw182
left a comment
Member
There was a problem hiding this comment.
There was definitely a bug that needs to be fixed here (relying on date modified is unreliable), but I'm nervous that this approach (the extract_savetime function) may also be unreliable and is overly strict on the filename convention currently used in climber.
Maybe no sorting should be done at all, with the assumption that filenames are input in the correct order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed way we order QL files during loading from date modified to save time (per the filename). This helps prevent ordering issues that arise when loading data with incorrect "date modified" information, like after downloading from Box.