Skip to content

Make plotting part of the base package - #478

Merged
iskandr merged 1 commit into
mainfrom
agent/make-plotting-core
Aug 2, 2026
Merged

Make plotting part of the base package#478
iskandr merged 1 commit into
mainfrom
agent/make-plotting-core

Conversation

@iskandr

@iskandr iskandr commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make matplotlib, adjustText, and matplotlib-venn standard oncoref dependencies
  • remove the plots extra and its optional-install documentation
  • make plotting tests fail rather than skip when the installation is incomplete
  • verify the clean base-install CI environment includes every plotting dependency

Rationale

Oncoref ships plotting modules and plot CLI commands as supported package features. Requiring a separate extra made a normal installation behaviorally incomplete and allowed missing plotting dependencies to suppress test coverage.

Validation

  • ./test.sh: 1042 passed, zero skipped
  • Ruff check and format checks pass
  • wheel build succeeds and declares all three plotting libraries as unconditional Requires-Dist entries

@iskandr
iskandr marked this pull request as ready for review August 2, 2026 20:06
@iskandr
iskandr merged commit 4965805 into main Aug 2, 2026
6 checks passed
@iskandr
iskandr deleted the agent/make-plotting-core branch August 2, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant