fix(dkg): align register key-length checks with the kernel encoding#844
Merged
Conversation
register() pinned dkgPubKey to 64 bytes and enclaveCommKey to 65 bytes, but the kernel produces (and the CL verifies) a 32-byte ed25519 dkgPubKey and a 64-byte secp256k1 commKey, so every registration reverted on length. Require 32/64 to match the kernel; both stay fixed-length, so the abi.encodePacked report-data preimage stays injective.
0xHansLee
requested review from
LeoHChen,
gezerui0124,
jdubpark,
lucas2brh,
ramtinms and
stevemilk
as code owners
June 12, 2026 08:19
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
stevemilk
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DKG.sol::registerpinsdkgPubKeyto 64 bytes andenclaveCommKeyto 65 bytes, but the kernel produces — and the consensus client verifies — a 32-byte ed25519dkgPubKeyand a 64-byte secp256k1commKey(uncompressed,0x04prefix stripped). Everyregistertherefore reverts on the length check, so DKG cannot bootstrap on any chain running the current contracts.The strict checks were added in #831 (previously the fields were only required to be non-empty), which is why this surfaced only after the up-to-date contracts were actually deployed.
Fix
Require
dkgPubKey == 32andenclaveCommKey == 64to match what the kernel emits and the CL verifies. Both fields stay fixed-length, so theabi.encodePackedreport-data preimage remains injective andcalculateReportDatastill mirrors it.issue: piplabs/story-kernel#73