Skip to content

fix(sdk): tolerate null pipe rows in discovery - #857

Open
adriannoes wants to merge 1 commit into
devfrom
ad-dev/fix/search-pipes-null-rows
Open

adriannoes wants to merge 1 commit into
devfrom
ad-dev/fix/search-pipes-null-rows

Conversation

@adriannoes

@adriannoes adriannoes commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Skip null pipe rows in search_pipes for named and unfiltered searches.
  • Preserve valid results, fuzzy ranking, caps, and pipesCount. Mark results incomplete when the API includes a null row.
  • Treat a null pipe list as empty and keep upstream errors visible. Add no retry or API request.
  • Explain null rows in the SDK, MCP description, and organization reference. A truncation flag alone does not prove a cap cut.

Test plan

  • uv run pytest -m "not integration" (CI: 5,686 passed, 6 skipped, 46 deselected).
  • uv run ruff check . && uv run ruff format --check . (CI).
  • Focused SDK and facade tests: 60 passed, including 10 regression cases.
  • Ruff and formatting passed for the three changed Python files.
  • Manual smoke (if applicable).

Focused command: python -m pytest -q -p no:cacheprovider packages/sdk/tests/services/test_pipe_service.py packages/sdk/tests/services/test_pipefy_client.py::test_search_pipes_delegates_to_pipe_service --tb=short.

Docs / skills

  • docs/parity.md updated when MCP ↔ CLI coverage changed (not applicable).
  • Affected skills in plugins/pipefy/skills/ updated in this PR (or a paired PR) (not applicable).
  • Update the SDK docstring, MCP description, and docs/mcp/tools/organization.md for null rows and incomplete results.
  • No skill update needed. This correction changes no tool name, parameter, or MCP/CLI coverage.

Legal / contributions

  • Commits include DCO sign-off (git commit -s).
  • Regulated-domain skills include COMPLIANCE.md when applicable (not applicable).

Signed-off-by: Adrianno Esnarriaga <hey@adrianno.es>
@adriannoes adriannoes self-assigned this Nov 9, 2026
@adriannoes adriannoes added bug Defect: incorrect or broken behavior vs documented contract reliability Correctness under failure: retries, idempotency, false errors, resilience labels Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Defect: incorrect or broken behavior vs documented contract reliability Correctness under failure: retries, idempotency, false errors, resilience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant