Examples: use ghcr helloworld image instead of gcr - #7414
Merged
Merged
Conversation
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
✅ Deploy Preview for pipecd-site canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7414 +/- ##
=======================================
Coverage 30.35% 30.36%
=======================================
Files 601 601
Lines 52622 52622
=======================================
+ Hits 15975 15977 +2
+ Misses 35128 35125 -3
- Partials 1519 1520 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Two Helm values files omit the required image.tag, causing invalid rendered image references.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Updates examples from the deprecated GCR Hellworld image to the GHCR image, using compatible tags.
Changes:
- Migrates image references to
ghcr.io/pipe-cd/helloworld. - Updates selected tags to
v0.48.0. - Updates the event-watcher image replacement regex.
| File | Summary |
|---|---|
examples/v1/local-modules/helm-charts/helloworld/values.yaml |
GHCR repository updated; image.tag is still missing. |
examples/v1/kubernetes/helm-local-chart/values.yaml |
GHCR repository and tag updated. |
examples/v0/local-modules/kustomize-bases/helloworld/deployment.yaml |
GHCR image updated. |
examples/v0/local-modules/helm-charts/helloworld/values.yaml |
GHCR repository updated; image.tag is still missing. |
examples/v0/kubernetes/script-run/deployment.yaml |
GHCR image and tag updated. |
examples/v0/kubernetes/kustomize-local-base/kustomization.yaml |
GHCR image and tag updated. |
examples/v0/kubernetes/helm-local-chart/values.yaml |
GHCR repository and tag updated. |
examples/v0/cloudrun/wait-approval/service.yaml |
GHCR image and tag updated. |
examples/v0/cloudrun/simple/service.yaml |
GHCR image and tag updated. |
examples/v0/cloudrun/secret-management/service.yaml |
GHCR image and tag updated. |
examples/v0/cloudrun/canary/service.yaml |
GHCR image and tag updated. |
examples/v0/cloudrun/analysis/service.yaml |
GHCR image and tag updated. |
examples/.pipe/event-watcher-using-regex.yaml |
Image replacement regex updated for GHCR. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
khanhtc1202
enabled auto-merge (squash)
September 25, 2026 09:46
Contributor
|
Thank you for contributing to PipeCD, @rahulshendre! The changes in this pull request will be part of the upcoming release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Switches the examples from
gcr.io/pipecd/helloworldtoghcr.io/pipe-cd/helloworld.The old tags used here (v0.5.0, v0.6.0, v0.27.4) are only available on gcr, so they are updated to
v0.48.0, which is on ghcr and supports both amd64 and arm64. Cloud Run can pull public ghcr images now, so the cloudrun examples work as well.v0/kubernetes/kustomize-remote-baseis left unchanged since it depends on an external base repoWhy we need it:
gcr.io/pipecd is being removed.
Which issue(s) this PR fixes:
Part of #7385
Does this PR introduce a user-facing change?:
Screenshots/Videos (for documentation or website changes):
Attach a screenshot or screen recording if your PR modifies any files under
docs/or any.md/.mdxfiles. Run the site locally usingmake run/siteand verify your changes before submitting.