Remove gcr registry from workflows - #7386
Merged
Merged
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
✅ Deploy Preview for pipecd-site canceled.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes consistently remove obsolete GCR publishing and use GHCR exclusively.
Pull request overview
This PR removes GCR publishing and standardizes PipeCD artifact publication on GHCR.
Changes:
- Removes GCR authentication and publishing paths.
- Updates experimental and release workflows to GHCR-only publishing.
- Removes the obsolete GCR chart publishing target.
File summaries
| File | Description |
|---|---|
Makefile |
Removes the legacy chart publishing target. |
.github/workflows/publish_pipedv1_exp.yaml |
Publishes experimental images only to GHCR. |
.github/workflows/publish_image_chart.yaml |
Publishes release images only to GHCR. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7386 +/- ##
==========================================
- Coverage 29.79% 29.78% -0.01%
==========================================
Files 601 601
Lines 64448 64448
==========================================
- Hits 19200 19196 -4
- Misses 43756 43759 +3
- Partials 1492 1493 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
All PipeCD artifacts are currently hosted on ghcr; removing unnecessary gcr support reduces maintenance and infrastructure costs.
Which issue(s) this PR fixes:
Part of #7385
Does this PR introduce a user-facing change?:
Screenshots/Videos (for documentation or website changes):
Attach a screenshot or screen recording if your PR modifies any files under
docs/or any.md/.mdxfiles. Run the site locally usingmake run/siteand verify your changes before submitting.