Examples: Add v1 Kubernetes helm-local-chart example - #7280
Merged
mohammedfirdouss merged 1 commit intoSep 3, 2026
Merged
Conversation
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
✅ Deploy Preview for pipecd-site canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7280 +/- ##
==========================================
- Coverage 29.74% 28.86% -0.89%
==========================================
Files 601 529 -72
Lines 64442 58381 -6061
==========================================
- Hits 19166 16849 -2317
+ Misses 43784 40166 -3618
+ Partials 1492 1366 -126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a PipeCD v1 (pipedv1 plugin-based) Kubernetes example showing how to deploy a Helm chart that lives in the same Git repository, under examples/v1/, aligning with the “Prepare examples for pipedv1” effort in #6266.
Changes:
- Introduces a local Helm chart module (
examples/v1/local-modules/helm-charts/helloworld) with standard templates. - Adds a v1 Application config and values for deploying that local chart via the Kubernetes plugin.
- Provides Helm chart auxiliary files (NOTES, tests, helpers, ignore rules).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/v1/local-modules/helm-charts/helloworld/values.yaml | Chart default values for the local “helloworld” Helm chart. |
| examples/v1/local-modules/helm-charts/helloworld/templates/tests/test-connection.yaml | Helm test hook pod to validate service reachability. |
| examples/v1/local-modules/helm-charts/helloworld/templates/serviceaccount.yaml | ServiceAccount template for the chart. |
| examples/v1/local-modules/helm-charts/helloworld/templates/service.yaml | Service template exposing the app. |
| examples/v1/local-modules/helm-charts/helloworld/templates/NOTES.txt | Post-install notes/instructions for accessing the app. |
| examples/v1/local-modules/helm-charts/helloworld/templates/ingress.yaml | Optional Ingress template for exposing the service. |
| examples/v1/local-modules/helm-charts/helloworld/templates/deployment.yaml | Deployment template for running the helloworld container. |
| examples/v1/local-modules/helm-charts/helloworld/templates/_helpers.tpl | Shared helper templates (names, labels, service account name). |
| examples/v1/local-modules/helm-charts/helloworld/Chart.yaml | Helm chart metadata for the local module chart. |
| examples/v1/local-modules/helm-charts/helloworld/.helmignore | Files to ignore when packaging the chart. |
| examples/v1/kubernetes/helm-local-chart/values.yaml | Example app-specific Helm values override for the deployment. |
| examples/v1/kubernetes/helm-local-chart/app.pipecd.yaml | PipeCD v1 Application spec demonstrating helmChart.path usage. |
Suppressed comments (1)
examples/v1/local-modules/helm-charts/helloworld/templates/NOTES.txt:20
- The port-forward command forwards to pod port 80, but the container exposes port 9085 (named
http) intemplates/deployment.yaml. This makes the NOTES instructions fail when users follow them.
kubectl --namespace {{ .Release.Namespace }} port-forward $POD_NAME 9085:80
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+7
to
+10
| image: | ||
| repository: gcr.io/pipecd/helloworld | ||
| pullPolicy: IfNotPresent | ||
|
|
Comment on lines
+35
to
+38
| - path: {{ . }} | ||
| backend: | ||
| serviceName: {{ $fullName }} | ||
| servicePort: {{ $svcPort }} |
Comment on lines
+57
to
+63
| {{- define "helloworld.serviceAccountName" -}} | ||
| {{- if .Values.serviceAccount.create -}} | ||
| {{ default (include "helloworld.fullname" .) .Values.serviceAccount.name }} | ||
| {{- else -}} | ||
| {{ default "default" .Values.serviceAccount.name }} | ||
| {{- end -}} | ||
| {{- end -}} |
Comment on lines
+4
to
+8
| {{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}} | ||
| apiVersion: networking.k8s.io/v1beta1 | ||
| {{- else -}} | ||
| apiVersion: extensions/v1beta1 | ||
| {{- end }} |
| echo http://$NODE_IP:$NODE_PORT | ||
| {{- else if contains "LoadBalancer" .Values.service.type }} | ||
| NOTE: It may take a few minutes for the LoadBalancer IP to be available. | ||
| You can watch the status of by running 'kubectl get --namespace {{ .Release.Namespace }} svc -w {{ include "helloworld.fullname" . }}' |
| trigger: | ||
| onCommit: | ||
| paths: | ||
| - local-modules/helm-charts/helloworld/* |
Contributor
Author
There was a problem hiding this comment.
These are all from the upstream Helm chart scaffold, carried over as-is from the v0 example - this is a straight v0 -> v1 port.
The example deploys cleanly (image.tag comes from the app-level values.yaml, ingress is disabled by default)
mohammedfirdouss
approved these changes
Sep 3, 2026
Contributor
|
Thank you for contributing to PipeCD, @rahulshendre! The changes in this pull request will be part of the upcoming release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds the v1 Kubernetes helm-local-chart example under examples/v1/
Why we need it:
Adds examples to v1 directory
Which issue(s) this PR fixes:
Part of #6266
Does this PR introduce a user-facing change?: