Examples: Add v1 kubernetes kustomize-local-base example - #7279
Open
rahulshendre wants to merge 2 commits into
Open
Examples: Add v1 kubernetes kustomize-local-base example#7279rahulshendre wants to merge 2 commits into
rahulshendre wants to merge 2 commits into
Conversation
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
✅ Deploy Preview for pipecd-site canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new PipeCD v1 Kubernetes example demonstrating how to deploy a Kustomize app that reuses a local base directory stored in the same Git repository, aligning with the ongoing pipedv1 examples work (part of #6266).
Changes:
- Add a reusable local Kustomize base module (
helloworld) with Deployment/Service manifests. - Add a v1 Kubernetes application example (
kustomize-local-base) that references the local base and overrides image tags. - Add a v1 Application config enabling the Kubernetes plugin with a pinned Kustomize version.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/v1/local-modules/kustomize-bases/helloworld/service.yaml | Adds Service manifest for the shared local Kustomize base. |
| examples/v1/local-modules/kustomize-bases/helloworld/kustomization.yaml | Defines the local base module’s resource composition. |
| examples/v1/local-modules/kustomize-bases/helloworld/deployment.yaml | Adds Deployment manifest for the shared local Kustomize base. |
| examples/v1/kubernetes/kustomize-local-base/kustomization.yaml | Adds the example overlay referencing the local base and overriding image tag. |
| examples/v1/kubernetes/kustomize-local-base/app.pipecd.yaml | Adds v1 Application config wiring the Kubernetes plugin and Kustomize version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
+2
| bases: | ||
| - ../../local-modules/kustomize-bases/helloworld |
Contributor
Author
There was a problem hiding this comment.
good catch although, bases worked fine, but it's deprecated, so i have switched to resources to be safe
Verified it still builds
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds the v1 Kubernetes kustomize-local-base example under examples/v1/
Why we need it:
Add v1 examples
Which issue(s) this PR fixes:
Part of #6266
Does this PR introduce a user-facing change?: