Skip to content

Save cancel plan preview command in pipecd command store - #5841

Closed
atpugtihsrah wants to merge 5 commits into
pipe-cd:masterfrom
atpugtihsrah:5276-cancel-plan-preview-eaz9fuv529
Closed

atpugtihsrah wants to merge 5 commits into
pipe-cd:masterfrom
atpugtihsrah:5276-cancel-plan-preview-eaz9fuv529

Conversation

@atpugtihsrah

@atpugtihsrah atpugtihsrah commented May 16, 2025 •

Copy link
Copy Markdown
Contributor

What this PR does: Adds a CancelPlanPreview command to cancel the plan preview and saves it in the command store in pipecd.

Why we need it: We want to be able to cancel commands that are no longer required to be completed so that resource consumption (therefore money expenditure) can be stopped.

Which issue(s) this PR fixes: Partly closes #5276

Fixes # #5276

Does this PR introduce a user-facing change?: Yes

  • How are users affected by this change: All
  • Is this breaking change: No
  • How to migrate (if breaking change): NA

@atpugtihsrah atpugtihsrah changed the title Cancel plan preview command Save cancel plan preview command in pipecd command store May 18, 2025
@Warashi

Warashi commented May 29, 2025

Copy link
Copy Markdown
Member

Sorry, we updated the CI and branch protection rules.
I updated the branch of this PR by pushing the Update branch button, which is the GitHub feature.
Please let me know if you see any unexpected behavior.

@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Jun 29, 2025
@atpugtihsrah

Copy link
Copy Markdown
Contributor Author

Still active.

@github-actions github-actions Bot removed the Stale label Jul 1, 2025
@atpugtihsrah atpugtihsrah self-assigned this Jul 22, 2025
@atpugtihsrah
atpugtihsrah force-pushed the 5276-cancel-plan-preview-eaz9fuv529 branch 2 times, most recently from 361c096 to a08cced Compare July 22, 2025 14:37
@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Aug 22, 2025
@github-actions

Copy link
Copy Markdown
Contributor

This PR was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable.

@github-actions github-actions Bot closed this Aug 30, 2025
@atpugtihsrah

Copy link
Copy Markdown
Contributor Author

Reopening PR

@atpugtihsrah atpugtihsrah reopened this Oct 20, 2025
@github-actions github-actions Bot removed the Stale label Oct 21, 2025
Signed-off-by: Harshit Gupta <hg2t4e@gmail.com>
Signed-off-by: Harshit Gupta <hg2t4e@gmail.com>
Signed-off-by: Harshit Gupta <hg2t4e@gmail.com>
Signed-off-by: Harshit Gupta <hg2t4e@gmail.com>
Signed-off-by: Harshit Gupta <hg2t4e@gmail.com>
@atpugtihsrah
atpugtihsrah force-pushed the 5276-cancel-plan-preview-eaz9fuv529 branch from a08cced to 6b159b6 Compare October 25, 2025 13:25
@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Nov 25, 2025
@github-actions

github-actions Bot commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

This PR was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable.

@github-actions github-actions Bot closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a way to cancel PlanPreview for pipedv1

2 participants