Riot Shields Resprites

[La-ryssa]

About the PR

Changed the sprites of the riot ballistic, reflective and basic riot shield to be more polished.

Why / Balance

The old sprites are noisy, messy, extremely old and don't make any sense. Things looking immersive is important for a roleplaying game.

Technical details

I change sprite

Media

Testing plan

I ran the game and held the shields

Known issues

I'm not entirely satisfied with the reflective shield and it's subject to change.

Changelog

🆑 Lady Death's Head

• tweak: Changed the sprites of all security shields to be more polished and immersive.

[github-actions]

RSI Diff Bot; head commit beb9b4d merging into 3930cc6
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Weapons/Melee/shields.rsi

State	Old	New	Status
riot-icon			Modified
riot-inhand-left			Modified
riot-inhand-right			Modified
riot_bullet-icon			Modified
riot_bullet-inhand-left			Modified
riot_bullet-inhand-right			Modified
riot_laser-icon			Modified
riot_laser-inhand-left			Modified
riot_laser-inhand-right			Modified

Edit: diff updated after beb9b4d

[arenaconspiracy]

You forgot to edit the attributions in the meta.json for the sprites, but besides that:

I would prefer this pull be more ambitious, cleaning up and remaking the upstream content. The sprites for each individual shield should be in their own separate RSI in the pinwheel subdirectory, with generic state names, and the upstream sprites should be deleted.

You and I have discussed in the past things such as removing makeshift shields and making shields wearable in suit storage, you can (and should) handle those here and now in the interest of time and brevity.
Feel free to ask me for directions if you're not sure what I meant, but I'll happily review the changes after if you can proceed on your own.

[arenaconspiracy]

Another note, I think the "near end" inhand sprites on the riot shield should be bumped out by one pixel, they currently leave the wielder's chest exposed visually.

[arenaconspiracy]

Upon some inspection, I think the laser shield's south inhand encroaches on the character's eyes too much, and the east/west inhands curve unlike the other shields. You could try to see about flattening the top out.
Also the ballistic's south inhand is a few pixels too high.

[imatsoup]

the ordinary ballistic shield is my favorite followed closely by the riot shield. i think the way the ballistic shield and the reflective shield sit on the character sprite when facing south isn't quite right, maybe you could bring them down a pixel or two to match a little better with the sideways facing sprites