ci: bump create-github-app-token v2→v3 for Node 24#47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
actions/create-github-app-tokenfrom@v2to@v3across every occurrence in this repo:actions/setup-go/action.yml(reusable composite action).github/workflows/docker-release.yml(reusable workflow).github/workflows/tag-config.ymlREADME.md(the template usage example, so what people copy stays current)Why
v2's
action.ymldeclaresusing: node20, which is deprecated on GitHub Actions runners and emits a Node 20 deprecation warning on every run. v3.2.0 declaresusing: node24, clearing the warning.Because
actions/setup-goanddocker-release.ymlhere are consumed by other pinpredict repos via@main(trading,magellan,dis,replay,trader-tools,service-template, ...), this single bump also clears the deprecation warning for every downstream caller.Breaking changes — none apply here
The v3.0.0 major bump carried two breaking changes, neither of which affects us:
NODE_USE_ENV_PROXY— we run on GitHub-hosted runners with no proxy, so this is a no-op.Step inputs (
app-id,private-key,owner,repositories) andoutputs.tokenare unchanged v2→v3, so no call sites need edits beyond the version string.