Skip to content

fix(discover-services): tolerate a .dockerignore with no allow-list lines #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blairham merged 1 commit into from
Jul 6, 2026
Merged

fix(discover-services): tolerate a .dockerignore with no allow-list lines #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion actions/discover-services/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,11 @@ runs:
# the image. We invert it: `!` lines are the allow-list; anything
# matching becomes a candidate for "docker-relevant change".
if [ -f .dockerignore ]; then
includes=$(grep '^!' .dockerignore | sed 's|^!||; s|[.]|\\.|g; s|/$|/.*|; s|\*|.*|g')
# `|| true`: a .dockerignore with no `!` allow-list lines makes
# grep exit 1, and `set -e` (with pipefail) would abort the whole
# detect job on that empty-match — same failure class as the
# SIGPIPE guard below. An empty `includes` is handled downstream.
includes=$(grep '^!' .dockerignore | sed 's|^!||; s|[.]|\\.|g; s|/$|/.*|; s|\*|.*|g' || true)
else
includes=""
fi
Expand Down