feat(pre-commit-advisory): run pre-commit via the go-pre-commit action#35
Merged
Conversation
Replaces the pip-installed Python pre-commit with blairham/go-pre-commit (install-only mode — this workflow keeps driving the diff-scoped run, the sticky PR comment, and the install-hooks cache seed itself). Cache key prefix bumped to go-pre-commit-* so Python-built hook envs are never restored into the Go implementation. setup-python stays for language: python hooks (ruff).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts blairham/go-pre-commit's action as the pre-commit provider in the advisory workflow, replacing
pip install pre-commit.install-only: 'true'— the workflow keeps driving pre-commit itself: the diff-scopedrun --from-ref/--to-ref(whose log feeds the sticky PR comment) and the push-to-maininstall-hookscache seed. Requires feat(action): add install-only input blairham/go-pre-commit#31 (adds the input) — merge that first.cache: 'false'on the action — the workflow's own cache step owns caching (it has restore-keys); its key prefix is bumped togo-pre-commit-*so hook envs built by the old Python pre-commit are never restored into the Go implementation.language: pythonhooks (ruff in magellan/trader-tools) still need an interpreter; go-pre-commit builds their venvs with the Python on PATH.v4.5.4(matches dev machines); action ref@mainuntil a release tag carries the new input.language: golanggolangci hooks.🤖 Generated with Claude Code