[#noissue] Add H2 ServiceType mapping for OTLP database spans - #13918
Open
jaehong-kim wants to merge 1 commit into
Open
[#noissue] Add H2 ServiceType mapping for OTLP database spans#13918jaehong-kim wants to merge 1 commit into
jaehong-kim wants to merge 1 commit into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13918 +/- ##
============================================
+ Coverage 33.19% 33.81% +0.62%
- Complexity 11535 11891 +356
============================================
Files 4152 4167 +15
Lines 97978 98847 +869
Branches 10387 10564 +177
============================================
+ Hits 32520 33428 +908
+ Misses 62646 62546 -100
- Partials 2812 2873 +61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds first-class H2 database ServiceType resolution for OTLP client/database spans, so H2 traces are categorized with Pinpoint’s H2/H2_EXECUTE_QUERY codes instead of falling back to UNKNOWN_DB.
Changes:
- Register H2 and H2_EXECUTE_QUERY via a new external type-provider YAML.
- Normalize
db.system/db.system.nameinputs (trim + lowercase) when resolving DB ServiceType codes. - Add/extend unit tests to cover H2 mapping and db.system normalization behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| otlptrace/otlptrace-collector/src/test/java/com/navercorp/pinpoint/otlp/trace/collector/mapper/OtlpTraceSpanEventMapperTest.java | Adds span-mapping tests to ensure H2 OTLP database spans map to H2/H2_EXECUTE_QUERY ServiceTypes. |
| otlptrace/otlptrace-collector/src/test/java/com/navercorp/pinpoint/otlp/trace/collector/mapper/OtlpDbSystemTypeResolverTest.java | Adds tests verifying db.system normalization (case/whitespace) for H2 base/execute-query resolution. |
| otlptrace/otlptrace-collector/src/main/java/com/navercorp/pinpoint/otlp/trace/collector/mapper/OtlpDbSystemTypeResolver.java | Normalizes db.system keys before lookup so resolution is tolerant to casing/whitespace. |
| agent-module/plugins/external/src/main/resources/META-INF/pinpoint/type-providers/h2-type-provider.yml | Introduces ServiceType definitions for H2 and H2_EXECUTE_QUERY (codes 2750/2751). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+14
| serviceTypes: | ||
| - code: 2750 | ||
| name: 'H2' | ||
| desc: 'H2' | ||
| property: | ||
| terminal: true | ||
| includeDestinationId: true | ||
| - code: 2751 | ||
| name: 'H2_EXECUTE_QUERY' | ||
| desc: 'H2_EXECUTE_QUERY' | ||
| property: | ||
| recordStatistics: true | ||
| terminal: true | ||
| includeDestinationId: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.