[#noissue] Make V4 gRPC apiKey optional and thread serviceUid through… - #13873
Open
emeroad wants to merge 1 commit into
Open
[#noissue] Make V4 gRPC apiKey optional and thread serviceUid through…#13873emeroad wants to merge 1 commit into
emeroad wants to merge 1 commit into
Conversation
… the application map - V4 apiKey is now optional: ClientHeaderFactoryV4 omits the API_KEY header when null, HeaderV4/ObjectNameV4 drop requireNonNull and mark apiKey @nullable, ServerHeaderReaderV4 reads it leniently, ObjectNameResolverV4 no longer fails when -Dpinpoint.apikey is absent - ServiceUid: Vertex gains an of(serviceUid, applicationName, serviceType) overload and includes serviceUid in toString; HbaseApplicationMapService builds the self-vertex with ServiceUid.DEFAULT; rename ServiceUid.TEST -> TEST_SERVICE (+ TEST_SERVICE_UID_NAME); DefaultServerRequestFactory resolves the serviceUid from the header service name
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… the application map