server: fence capture writes with etcd and P2P leases - #6092
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/test all |
|
@asddongmen: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #6045
A network-isolated capture can keep writing after the surviving coordinator schedules replacement dispatchers. This creates an old/new writer overlap and can leave a MySQL sink inconsistent even after the checkpoint advances.
What is changed and how it works?
Already-admitted MySQL transactions remain outside the strict guarantee: the gate cannot revoke a COMMIT already accepted by the downstream.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
The DML admission check is an in-memory gate. New heartbeat traffic runs every 500 ms. Enforcement is negotiated per node, so old nodes that do not advertise the capability keep legacy behavior during rolling upgrade.
Do you need to update user documentation, design documentation or monitoring documentation?
No user documentation change. New metrics expose write-lease state; the design remains an internal review draft until finalized.
Release note