Skip to content

server, dispatcher: improve node liveness self fence (#5106) #5764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ti-chi-bot merged 4 commits into from
Jul 28, 2026
Merged

server, dispatcher: improve node liveness self fence (#5106) #5764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
719542c
This is an automated cherry-pick of #5106
asddongmen Jun 12, 2026
d9b441e
server,dispatcher: resolve release-8.5 cherry-pick conflicts
asddongmen Jul 28, 2026
722e65e
server,dispatcher: keep release-8.5 mysql writer layout
asddongmen Jul 28, 2026
10bd7c0
sink: log MySQL hang failpoint activation
asddongmen Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions downstreamadapter/dispatcher/event_dispatcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,10 @@ func (d *EventDispatcher) Remove() {
d.removeDispatcher()
}

// EmitBootstrap emits the table bootstrap event in a blocking way after changefeed started
// It will return after the bootstrap event is sent.
func (d *EventDispatcher) EmitBootstrap() bool {
// EmitBootstrap emits the table bootstrap event in a blocking way after changefeed started.
// It will return after the bootstrap event is sent, or when shouldStop asks it
// to stop because the local write path has been fenced.
func (d *EventDispatcher) EmitBootstrap(shouldStop func() bool) bool {
bootstrap := loadBootstrapState(&d.BootstrapState)
switch bootstrap {
case BootstrapFinished:
Expand Down Expand Up @@ -204,9 +205,15 @@ func (d *EventDispatcher) EmitBootstrap() bool {
if table.IsView() {
continue
}
if shouldStop() {
return false
}
ddlEvent := codec.NewBootstrapDDLEvent(table)
err := d.sink.WriteBlockEvent(ddlEvent)
if err != nil {
if shouldStop() {
return false
}
log.Error("send bootstrap message failed",
zap.Stringer("changefeed", d.sharedInfo.changefeedID),
zap.Int("tables", len(currentTables)),
Expand All @@ -216,6 +223,9 @@ func (d *EventDispatcher) EmitBootstrap() bool {
d.HandleError(errors.ErrExecDDLFailed.GenWithStackByArgs())
return true
}
if shouldStop() {
return false
}
}
storeBootstrapState(&d.BootstrapState, BootstrapFinished)
log.Info("send bootstrap messages finished",
Expand Down
Loading
Loading