Skip to content

eventservice: backport adaptive scan window to release-8.5 - #5761

Merged
ti-chi-bot[bot] merged 8 commits into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-4030-to-release-8.5
Jul 28, 2026
Merged

eventservice: backport adaptive scan window to release-8.5#5761
ti-chi-bot[bot] merged 8 commits into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-4030-to-release-8.5

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Jul 27, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: ref #4172, ref #4365, ref #5041, ref #5394, ref #5546

The adaptive event-service scan-window feature is a complete sequence of changes. Backporting only its first PR would omit stability fixes, barrier progress fixes, and the rollback switch required for safe use on release-8.5.

What is changed and how it works?

This PR backports the complete series #4030#4460#4950#5395#5547 to release-8.5:

The backport also resolves release-8.5 conflicts while preserving its newer quota-release, filter-lifecycle, heartbeat-epoch, and dispatcher-metric fixes. The dashboard layout is adjusted to avoid overlapping panels.

Check List

Tests

Local validation:

  • make unit_test_pkg for eventservice, config, common event, eventcollector, dispatcher, and dynstream
  • cd tools/workload && go test ./...
  • make fmt
  • make cdc
  • make check

Questions

Will it cause performance regression or break compatibility?

No compatibility break is expected. The scan-window switch defaults to enabled and can disable the feature for rollback.

Do you need to update user documentation, design documentation or monitoring documentation?

No user or design documentation update is required. Event-service monitoring dashboards are updated.

Release note

Backport adaptive event-service scan-window control and barrier progress fixes to TiCDC 8.5.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jul 27, 2026
@ti-chi-bot

Copy link
Copy Markdown
Member Author

@asddongmen This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot

ti-chi-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3f5fba78-2ffb-4b25-bd00-3a9f17d68e92

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

Copy link
Copy Markdown
Member Author

Cherry-pick conflicts appear resolved; removing the do-not-merge/hold label.

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2026
@asddongmen asddongmen changed the title *:improve memory control (#4030) eventservice: backport adaptive scan window to release-8.5 Jul 27, 2026
@asddongmen

Copy link
Copy Markdown
Collaborator

/test all

@asddongmen

Copy link
Copy Markdown
Collaborator

/retest

@asddongmen

Copy link
Copy Markdown
Collaborator

/retest

@ti-chi-bot ti-chi-bot Bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 27, 2026
@asddongmen
asddongmen force-pushed the cherry-pick-4030-to-release-8.5 branch from b3db358 to 618b693 Compare July 28, 2026 07:05
@ti-chi-bot

ti-chi-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 28, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 23694fe into pingcap:release-8.5 Jul 28, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants