topsql: support detailed IO dimensions (#355) - #361
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Superseded by #362. The automated branch contains dependency conflict markers and is not writable by the author, so the resolved release-8.5 backport was opened from the jiong-nba fork. |
|
/close |
|
@jiong-nba: You can't close an active issue/PR unless you authored it or you are a collaborator. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #355
What problem does this PR solve?
Issue Number: ref #356
The Dashboard OP changes for detailed TopSQL IO dimensions need ng-monitoring to carry the new TiKV resource-usage data through storage and the
/topsql/v1/summaryAPI. Without this change, requests ordered by logical reads, logical writes, or RocksDB block reads cannot return the corresponding data.Related changes:
What is changed and how it works?
rocksdb_block_read_countfrom TiKV resource-usage records.logical_read,logical_write, andblock_readsummary order modes.logical_iomode and bothorder_byand legacyorderByrequest parameters.Dependency compatibility
The merged kvproto revision is source-incompatible with the previous PD client and client-go revisions because those clients still reference removed keyspace fields. An isolated module-resolution check showed that upgrading kvproto, PD client, and client-go together reproduces the current
go.modexactly. The matching clients require gRPC 1.82.1, x/net 0.56.0, and the related transitive versions.lumberjackis a direct dependency becauseutils/logutil/rotate.goimports it.Storage impact
Tests
GOTOOLCHAIN=go1.25.12 go test -mod=readonly ./component/topsql/store ./component/topsql/query ./component/topsql/service ./component/topsql/codec/plan ./component/topsql/subscriber ./component/topsqlGOTOOLCHAIN=go1.25.12 make test(all TopSQL and other packages passed; two existingconfigtests fail on this macOS host because its local IPv6 address is formatted without brackets)