Skip to content

Migrate deprecated google auth to GSI - #162

Open
gsipos wants to merge 1 commit into
pingcap:mainfrom
aliz-ai:migrate-deprecated-google-auth-to-gsi
Open

Migrate deprecated google auth to GSI#162
gsipos wants to merge 1 commit into
pingcap:mainfrom
aliz-ai:migrate-deprecated-google-auth-to-gsi

Conversation

@gsipos

@gsipos gsipos commented Mar 9, 2023

Copy link
Copy Markdown

The Google Sing-In Javascript platform library for Web has been deprecated, and will be unavailable after March 31, 2023.
This PR aims to resolve that by migrating to the newer GSI library.

https://developers.google.com/identity/oauth2/web/guides/migration-to-gis#library_quick_reference

solves #161

@gsipos

gsipos commented Mar 9, 2023

Copy link
Copy Markdown
Author

@breezewish fyi

@adaviding

Copy link
Copy Markdown

I am eagerly waiting for this issue to get resolved.

How can we get someone to review this, so that it can be merged? Maybe add them to Reviewers?

@gsipos

gsipos commented Mar 29, 2023

Copy link
Copy Markdown
Author

How can we get someone to review this, so that it can be merged? Maybe add them to Reviewers?

I don't have access to set reviewers, I believe only repo contributors can do that.

@adaviding

Copy link
Copy Markdown

@gregwebs This issue is actively blocking anybody using this wiki. The author does not have authority to add a reviewer. Can you please review this so we can get it merged?

@gregwebs

Copy link
Copy Markdown
Contributor

@gsipos LGTM. I don't have write access to this repo. Are you maintaining a fork?

@adaviding

Copy link
Copy Markdown

I am not maintaining a fork. @breezewish is the only other developer that I can see from the commit history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants