Skip to content

Fix Grafana dashboard script links#3158

Closed
wenxiaojie1 wants to merge 1 commit into
pingcap:mainfrom
wenxiaojie1:fix/grafana-dashboard-link-3157
Closed

Fix Grafana dashboard script links#3158
wenxiaojie1 wants to merge 1 commit into
pingcap:mainfrom
wenxiaojie1:fix/grafana-dashboard-link-3157

Conversation

@wenxiaojie1

Copy link
Copy Markdown

Fixes #3157.

This replaces the templated raw GitHub branch URL used for get-grafana-dashboards.sh in both English and Chinese monitor docs with the current main branch URL, so the link checker can resolve it.

Validation:

  • Verified https://raw.githubusercontent.com/pingcap/tidb-operator/main/hack/get-grafana-dashboards.sh returns HTTP 200.

@ti-chi-bot

ti-chi-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Jun 29, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

Welcome @wenxiaojie1!

It looks like this is your first PR to pingcap/docs-tidb-operator 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs-tidb-operator. 😃

@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Jun 29, 2026
@pingcap-cla-assistant

pingcap-cla-assistant Bot commented Jun 29, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 29, 2026
qiancai
qiancai previously approved these changes Jun 30, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 30, 2026
@qiancai

qiancai commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

/unapprove

@qiancai

qiancai commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

/lgtm cancel

@ti-chi-bot ti-chi-bot Bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 30, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-06-30 04:51:24.526885163 +0000 UTC m=+101426.227264576: ☑️ agreed by qiancai.
  • 2026-06-30 05:02:50.587474364 +0000 UTC m=+102112.287853777: ✖️🔁 reset by qiancai.

@qiancai qiancai dismissed their stale review June 30, 2026 05:05

this change is unnecessary

@qiancai

qiancai commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Hi @wenxiaojie1, thanks for creating this PR. However, this change is unnecessary because the error reported in #3157 is a false positive.

This error should not be triggered here, because the placeholder {{{ .tidb_operator_release_branch }}} will be automatically replaced with the corresponding release value before the Markdown document is rendered into HTML or PDF.

@qiancai qiancai closed this Jun 30, 2026
@wenxiaojie1

Copy link
Copy Markdown
Author

Thanks for clarifying. That makes sense; I missed that this placeholder is replaced before the rendered HTML/PDF output is generated. No further changes from me on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken Link Detected

2 participants