Fix Grafana dashboard script links#3158
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @wenxiaojie1! |
|
/unapprove |
|
/lgtm cancel |
|
Hi @wenxiaojie1, thanks for creating this PR. However, this change is unnecessary because the error reported in #3157 is a false positive. This error should not be triggered here, because the placeholder |
|
Thanks for clarifying. That makes sense; I missed that this placeholder is replaced before the rendered HTML/PDF output is generated. No further changes from me on this PR. |
Fixes #3157.
This replaces the templated raw GitHub branch URL used for
get-grafana-dashboards.shin both English and Chinese monitor docs with the currentmainbranch URL, so the link checker can resolve it.Validation:
https://raw.githubusercontent.com/pingcap/tidb-operator/main/hack/get-grafana-dashboards.shreturns HTTP 200.