Skip to content

Make file deletion idempotent in PeerStorage #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pike00 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make file deletion idempotent in PeerStorage #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions PeerStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ export class PeerStorage extends Peer {
await Deno.remove(path);
this.receiveLog(` ${path} deleted`);
} catch (ex) {
if (ex instanceof Deno.errors.NotFound) {
// Ignore NotFound error if the file was already deleted
return true;
}
this.receiveLog(` ${path} delete failed`, LOG_LEVEL_NOTICE);
Logger(ex, LOG_LEVEL_VERBOSE);
return false;
Expand Down
Loading