Skip to content

Fixed banner Y Position for iPhone X #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
csknns wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed banner Y Position for iPhone X #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion EBBannerView/Classes/EBBannerView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#import "EBCustomBannerView.h"
#import "EBBannerView+Categories.h"
#import "EBBannerWindow.h"
#import <sys/utsname.h>

NSString *const EBBannerViewDidClickNotification = @"EBBannerViewDidClickNotification";

Expand Down Expand Up @@ -96,12 +97,44 @@ -(void)show{

WEAK_SELF(weakSelf);
[UIView animateWithDuration:self.animationDuration animations:^{
weakSelf.frame = CGRectMake(0, 0, ScreenWidth, weakSelf.standardHeight);
weakSelf.frame = CGRectMake(0, [self bannerFinalYPosition], ScreenWidth, weakSelf.standardHeight);
} completion:^(BOOL finished) {
_hideTimer = [NSTimer scheduledTimerWithTimeInterval:weakSelf.stayDuration target:weakSelf selector:@selector(hide) userInfo:nil repeats:NO];
}];
}

-(CGFloat)bannerFinalYPosition{
CGFloat YPosition = 0.0f;

//The Y position of the banner notification view in Portrait orientation for iPhone X is 30pt
if ([self iSiPhoneX] && UIDeviceOrientationIsPortrait(UIDevice.currentDevice.orientation)) {
YPosition = 30.0f;
}

return YPosition;
}

-(BOOL)iSiPhoneX{
static BOOL isiPhoneX = NO;
static dispatch_once_t onceToken;

dispatch_once(&onceToken, ^{
#if TARGET_IPHONE_SIMULATOR
NSString *model = NSProcessInfo.processInfo.environment[@"SIMULATOR_MODEL_IDENTIFIER"];
#else

struct utsname systemInfo;
uname(&systemInfo);

NSString *model = [NSString stringWithCString:systemInfo.machine
encoding:NSUTF8StringEncoding];
#endif
isiPhoneX = [model isEqualToString:@"iPhone10,3"] || [model isEqualToString:@"iPhone10,6"];
});

return isiPhoneX;
}

+(void)showWithContent:(NSString*)content{
EBBannerViewStyle style = [UIDevice currentDevice].systemVersion.intValue;
EBBannerView *bannerView = [EBBannerView bannerViewWithStyle:style];
Expand Down