Feature 83 - #254
Open
ARSHIL1804 wants to merge 3 commits into
Open
Conversation
-added expantion annel for Archive polls in mypolls page -added a checkbox to archive poll in poll page -make sure to not delete poll if it is archived Todo : -warning pop up on checkbox marked if ended poll has been deleted from server
|
|
mensch72
reviewed
Oct 18, 2023
mensch72
reviewed
Oct 18, 2023
mensch72
reviewed
Oct 18, 2023
mensch72
requested changes
Oct 18, 2023
mensch72
left a comment
mensch72
left a comment
Collaborator
There was a problem hiding this comment.
Hi @ARSHIL1804 , sorry for taking so long to look at this. This looks fine and works like a charm. I have just a very few requests for minor changes, see my comments in the files. Could you do those before I merge? Thank you!
mensch72
approved these changes
Oct 22, 2023
mensch72
left a comment
mensch72
left a comment
Collaborator
There was a problem hiding this comment.
thank you for this professional and swift contribution!!
Collaborator
|
Oh, I realize your commits are not signed, and we require this for legal reasons to be able to prove later on that all commits were by people who have signed the CLA. Is there a way for you to sign those commits? Maybe this helps: https://webdevstudios.com/2020/05/26/retroactively-sign-git-commits/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.