Fix problems from repository split - #1
Open
sieben-gea wants to merge 7 commits into
Open
Conversation
The LPJmL componets moved to their own repository: https://github.com/pik-copan/pycopanlpjml InSEEDS models can also be found separately: https://github.com/pik-copan/inseeds
This is necessary, because the it was chnaged in networkx since version 2.0.
sieben-gea
force-pushed
the
s_fix_examples
branch
from
July 7, 2026 13:51
026f8bf to
7a3e2e1
Compare
sieben-gea
marked this pull request as ready for review
July 7, 2026 13:54
Collaborator
Author
|
Since I documented the models will only work with a newer version of pycopancore, this PR can be merged as is (notwithstanding any other issues you identify in review). Once released, the version in the |
Also disable overzealous style linting by flake8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is as far as I can get without someone from the original model developers taking a look at their old models. I documented the problems I could not resolve in #2.
For this to fully work, the changes from pik-copan/pycopancore#214 and pik-copan/pycopancore#212 need to be released.