Skip to content

Validate defun declaration forms in all environments #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pierre-rouleau wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Validate defun declaration forms in all environments #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Copyright (C) 2020-2026 by Pierre Rouleau

# Author: Pierre Rouleau <prouleau001@gmail.com>
# Last Modified Time-stamp: <2026-06-03 23:14:01 EDT, updated by Pierre Rouleau>
# Last Modified Time-stamp: <2026-06-04 12:27:43 EDT, updated by Pierre Rouleau>
# Keywords: packaging, build-control

# This file is part of the PEL package
Expand Down Expand Up @@ -660,7 +660,7 @@ endif
# - Compile pel_keys.el and pel.el at the end.

all: build/.check-init-stamp pel-top $(ALL_TEST_PASSED) pel_keys.elc pel.elc \
build/.compile-user-init-stamp
validate-declarations build/.compile-user-init-stamp
Comment on lines 662 to +663

@coderabbitai coderabbitai Bot Jun 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Enforce validation ordering with an explicit dependency edge.

Line 662 currently makes validate-declarations and build/.compile-user-init-stamp sibling prerequisites of all, so under make -j they can run concurrently. That does not guarantee declaration validation completes before user init compilation.

Suggested Makefile fix 
 all: build/.check-init-stamp pel-top $(ALL_TEST_PASSED) pel_keys.elc pel.elc \
      validate-declarations build/.compile-user-init-stamp
+
+# Ensure user init compilation starts only after declaration validation passes.
+build/.compile-user-init-stamp: validate-declarations
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
all: build/.check-init-stamp pel-top $(ALL_TEST_PASSED) pel_keys.elc pel.elc \
build/.compile-user-init-stamp
validate-declarations build/.compile-user-init-stamp
all: build/.check-init-stamp pel-top $(ALL_TEST_PASSED) pel_keys.elc pel.elc \
validate-declarations build/.compile-user-init-stamp
# Ensure user init compilation starts only after declaration validation passes.
build/.compile-user-init-stamp: validate-declarations
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Makefile` around lines 662 - 663, The Makefile's "all" target lists
validate-declarations and build/.compile-user-init-stamp as sibling
prerequisites which allows them to run in parallel under make -j and can let
user init compilation start before validation finishes; change the dependency
graph so build/.compile-user-init-stamp depends on validate-declarations (i.e.,
add validate-declarations as a prerequisite of build/.compile-user-init-stamp or
add an explicit ordering rule like build/.compile-user-init-stamp:
validate-declarations) so validate-declarations always completes before
build/.compile-user-init-stamp runs while leaving "all" unchanged.


pel-top: build/.check-init-stamp $(ALL_TEST_PASSED) $(ELC_FILES)

Expand Down
Loading