Skip to content

Remove setup offer selection authority - #12

Merged
Pluglug merged 1 commit into
mainfrom
website/gumroad-version-setup-client
Aug 26, 2026
Merged

Remove setup offer selection authority#12
Pluglug merged 1 commit into
mainfrom
website/gumroad-version-setup-client

Conversation

@Pluglug

@Pluglug Pluglug commented Aug 26, 2026

Copy link
Copy Markdown
Member

Delivery Contract

  • delivery mode: child
  • actual base: main
  • root/control-plane: pie-menu-editor/pie-menu-editor-service#45
  • root checklist: V3 setup client simplification
  • independently acceptable on website main: yes

Summary

  • setup URLから公開offer queryを除去し、claim requestへoffer_codeを送らない
  • claim retryを単一のcanonical namespaceへ統合する
  • 旧offer別pending retryは同じidempotency keyへ移し、開いている旧タブの復旧参照は完了または期限切れまで維持する
  • claim、Update Extension、status、reissueのoperation分離とsecret非保存を維持する
  • updates_throughはservice応答からの結果表示に限定する

Validation

  • npm test (19/19)
  • git diff --check
  • setup source scan: PUBLIC_OFFER_CODESofferCodeoffer_code?offerなし

Related: pie-menu-editor/pie-menu-editor-service#45, pie-menu-editor/pie-menu-editor-service#36

Branch: website/gumroad-version-setup-client

@Pluglug

Pluglug commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

@codex security review

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying pie-menu-editor-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 596b947
Status: ✅  Deploy successful!
Preview URL: https://8fc6ea31.pie-menu-editor-website.pages.dev
Branch Preview URL: https://website-gumroad-version-setu.pie-menu-editor-website.pages.dev

View logs

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 596b947b1f

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@Pluglug
Pluglug merged commit ca5795d into main Aug 26, 2026
2 checks passed
@Pluglug
Pluglug deleted the website/gumroad-version-setup-client branch August 26, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant