Adds a column with the argument secret=True to Table._meta.secret_columns - #1235
Merged
Merged
Conversation
dantownsend
reviewed
Jul 30, 2025
dantownsend
left a comment
Member
There was a problem hiding this comment.
Thanks for this - it looks good, just a few minor comments 👍
| email_columns.append(column) | ||
|
|
||
| if isinstance(column, Secret): | ||
| if isinstance(column, Secret) or column._meta.secret: |
Member
There was a problem hiding this comment.
I don't think we need to check isinstance(column, Secret) - just column._meta.secret alone should work, because Secret columns should have column._meta.secret = True.
| """ | ||
|
|
||
| class Classified(Table): | ||
| top_secret = Varchar(secret=True) |
Member
There was a problem hiding this comment.
As a sanity check, add a non-secret column here too, to make sure only secret columns are added to _meta.secret_columns. For example:
class Classified(Table):
top_secret = Varchar(secret=True)
public = Varchar()You might also consider merging this test with the above test, so we have this:
def test_secret_columns(self):
"""
Make sure ``TableMeta.secret_columns`` are setup correctly.
"""
class Classified(Table):
top_secret = Secret()
confidential = Varchar(secret=True)
public = Varchar()
self.assertEqual(
Classified._meta.secret_columns,
[Classified.top_secret, Classified.confidential]
)
Member
|
This is good to go once the CI passes - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #918. Code written by @patrickneise (here) but never create PR. Thanks @patrickneise.