fix(media): confina auto-follow da letra ao aside - #145
Open
rafaumeu wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
modulo:ui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Ronaldo Lyma reportou que o aside que acompanha a letra projetada quebrava/deslocava o layout.
Causa
scrollIntoView({ behavior: 'smooth' })era executado a cada troca de slide e podia rolar ancestrais além da lista lateral, acumulando animações.Fix
scrollIntoViewaside.scrollTo({ behavior: 'auto' })Verificação
media-aside-scroll.test.ts: 2/2npm run type-checknpm run buildEvidência original:
/home/rafaelejosi/Downloads/document_4949988093978480885.mp4