Introduce compact module view node#284
Open
jmdowrick wants to merge 9 commits into
Open
Conversation
- Move zoom limits back to constants - Introduce compactMode
CSS burden too high when lots of module nodes.
Reduces the computational cost of reformatting. Smoother transition.
Optimise rerender to remove freeze that happened when zooming in and out.
Collaborator
I have a problem with fitting the whole workflow in. |
Collaborator
Author
|
This was intentional to ensure that the module names never get too small. Can be "fixed" by updating the ZOOM_LIMITS constants in the utils/constants.js file. |
Not being able to see the full model was not enjoyed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the contents of the modules nodes depending on the zoom state.
Compact mode removes most of the content, making the module name much more visible and moving the buttons to a dropdown triggered by a single button in the module's corner.
I've played around with optimisations to smooth out the transition, and it's OK(ish) on my screen. Would like a few people to try it out before we merge it into production.
I also changed the zoom limits so the module name remains visible at the minimum zoom. It's nice to see all the modules in theory, but it's not useful if you can't identify what they are.
Resolves #94.