feat(plots): maximize an individual output plot to fill the middle window (#115)#120
Merged
Merged
Conversation
FinbarArgus
force-pushed
the
feat/maximize-individual-plots-115
branch
from
July 24, 2026 06:04
58de18f to
59f3283
Compare
…ndow (#115) Per the issue comment, the "maximize all plots" case is already covered by dragging the LHS/RHS columns away; what was missing is maximizing an *individual* plot. Each output plot now has a maximize/restore button in its header; clicking it expands that plot to fill the Output-plots area (hiding the other plots, group headings and the Add-plot row), and clicking again restores the grid. - PlotPanel.vue: `maximizable` / `maximized` props + `toggle-maximize` event; a header button (pi-window-maximize / -minimize) with title + aria-pressed. - App.vue: `maximizedPlot` key + `toggleMaximizePlot`; a self-correcting `effectiveMaximized` computed so a stale key (plot removed, or the sim regenerates cells) falls back to the normal grid instead of a blank view. CSS expands the single visible cell to full height. Tests: PlotPanel (button gating, emit, icon/title/aria per state) and App (toggle on/off/switch, stale-key fallback). Frontend 298; build clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
FinbarArgus
force-pushed
the
feat/maximize-individual-plots-115
branch
from
July 24, 2026 07:13
59f3283 to
c8c0d01
Compare
After un-maximizing, the plot's y-axis stayed stretched: Chart.js with maintainAspectRatio:false grows the canvas to fill the maximized window but doesn't shrink it back on restore — the enlarged canvas keeps inflating its auto-height container, so the cell stays tall. Key the <Line> on the maximize state so the chart remounts when it toggles: the stale large canvas is destroyed and a fresh one sizes to the restored (grid) cell. Test: toggling `maximized` recreates the Line instance (new vm) each way. Frontend 306; build clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115.
Per the issue comment, "maximize all plots" is already handled by dragging the LHS/RHS columns away — what was missing is maximizing an individual plot. Each output plot now has a maximize/restore button in its header: click it and that plot fills the Output-plots area (other plots, group headings and the Add-plot row hidden); click again to restore the grid.
PlotPanel.vue:maximizable/maximizedprops +toggle-maximizeevent; header button (pi-window-maximize/-minimize) with title +aria-pressed.App.vue:maximizedPlotkey +toggleMaximizePlot; a self-correctingeffectiveMaximizedcomputed so a stale key (plot removed, or the sim regenerates cells) falls back to the normal grid instead of a blank view. CSS expands the single visible cell to full height.Tests: PlotPanel (button gating, emit, icon/title/aria per state) + App (toggle on/off/switch, stale-key fallback). Frontend 298;
yarn buildclean.🤖 Generated with Claude Code