Repository navigation
Fix TigerTag "New Fields" fixture and message comments - #2
Closed
TigerTag-Project wants to merge 1 commit into
Closed
TigerTag-Project wants to merge 1 commit into
TigerTag-Project wants to merge 1 commit into
Conversation
- Give the synthetic fixture a real NTAG215 header (UID with BCC bytes and capability container), so the reader's physical-size check can read it - Swap the inverted nozzle temperatures (min 190, max 230) - Update comments to match the current TigerTag spec: the custom message is 28 bytes of free UTF-8 text with no reserved emoji prefix
TigerTag-Project
force-pushed
the
fix-pr18-tigertag-fixture
branch
from
October 13, 2026 20:13
1be66a4 to
9e98e26
Compare
Author
|
Closing in favour of suchmememanyskill#32, which includes your commits plus this fix directly against upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @physicsG, thanks for adding the custom message and bed temperature to the TigerTag parser!
This PR targets your branch for suchmememanyskill#18, so the fixes land directly in your PR.
Changes
main,test_physical_dump_preserves_processor_output[New Fields TigerTag]fails withKeyError: 0. The new reader test (from the NTAG216 support) reads the NTAG size byte from the capability container (byte 14), and the synthetic.binhad zeros there.build_tigertag_fixture.pynow writes a real NTAG215 header: a 7-byte UID with its BCC check bytes, plus the capability containerE1 10 3E 00.+48(pages0x10-0x16). There is no reserved emoji prefix anymore; emoji are just regular UTF-8 characters. The comments inconstants.pyandprocessor.pynow say this, and note that+76..+78is Measure Available (not reserved). The parsing code is unchanged, since it already matches the spec..binand.ymlwere regenerated withtest/scripts/build_tigertag_fixture.py.Tests
main: 97 passed, 1 skipped